Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Make title in product form required in validation to prevent error in storefront #340

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

jrw421
Copy link
Contributor

@jrw421 jrw421 commented Feb 1, 2021

Signed-off-by: jrw421 [email protected]

Resolves #304
Impact: minor
Type: bugfix

Issue

Admin can save and publish a product without adding its title. This product, when published, is naturally displayed on the storefront side. When the customer tries to open PDP for that product, the system throws 404 Not Found error (in case of Mac) and Sorry! We couldn't find what you're looking for error (in case of Ubuntu).

Solution

Make title a required field in the new product form to prevent further issues. Additionally will be adding error handling on the example-storefront to mitigate pre-existing issues.

Breaking changes

None expected.

Testing

  1. Go to Product -> Create product
  2. Create a product but leave the title field empty.
  3. Save the product.
  4. The form should prevent the user from saving and give the error Title is required.
  5. Add a title and press save.
  6. The product should save successfully.

@jrw421 jrw421 merged commit fa2bda7 into trunk Feb 5, 2021
@jrw421 jrw421 deleted the fix-304-jrw421-product-title branch February 5, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 on PDP when admin saves a product without title
2 participants